Skip to content

C107481: Fixing CDATA formatting #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

C107481: Fixing CDATA formatting #2829

wants to merge 1 commit into from
+29 −57

Conversation

v-maudel
Copy link
Contributor

@v-maudel v-maudel commented Jul 25, 2019 •
edited
Loading

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: the Markdown CDATA content is incorrectly formatted in source files, moreover it is breaking the target publishing builds since the content inside those tags are being processed as XML tag instead of Markdown content.

@v-maudel
C107481: Fixing CDATA formatting
d628f27 
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.  
Description: the Markdown CDATA content is incorrectly formatted in source files, moreover it is breaking the target publishing builds since the content inside those tags are being processed as XML tag instead of Markdown content.
@v-maudel
Copy link
Contributor Author

@mairaw @carlossanlop, please, help reviewing and merging this PR if agree.
Regards.

mairaw
mairaw approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me @v-maudel. There are some similar changes being made on PR https://github.com/dotnet/dotnet-api-docs/pull/2825/files. I'll make sure there's no more left after #2825 is merged.

@mairaw mairaw added the loc Indicates issues that are about localized content label Jul 25, 2019
@mairaw mairaw added this to the July 2019 milestone Jul 25, 2019
carlossanlop
carlossanlop approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for letting us know about this issue. I didn't know the CDATA lines could cause trouble. I will let people know about it.

@v-maudel
Copy link
Contributor Author

Thanks so much @mairaw ,
We received (From Loc team) the same issue for 7 more files. Although, by checking your linked PR, those CDATA issues were fixed as well.

@v-maudel v-maudel closed this Jul 25, 2019
@v-maudel
Copy link
Contributor Author

@mairaw , Do you know where this PR will be merged? Actually these issues are preventing some files to be localized.
FYI @carlossanlop

@mairaw
Copy link
Contributor

mairaw commented Jul 25, 2019

It’ll be merged to master this afternoon @v-maudel

@v-maudel
Copy link
Contributor Author

@mairaw Thanks!

@mairaw mairaw reopened this Jul 26, 2019
@mairaw
Copy link
Contributor

mairaw commented Jul 26, 2019

Closing. Never mind. I thought that this specific change wasn't included but it seems my PR fixed it.

@mairaw mairaw closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@v-maudel v-maudel

Labels
loc Indicates issues that are about localized content
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@v-maudel @mairaw @carlossanlop